fix: repair failing tests and type errors across api and shared packages#58
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests and type errors across api and shared packages#58stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and TypeScript type errors in the multi-package Bun + Hono API repo.
bun testnow reports 22 pass / 0 fail andtsc --noEmitis clean.Changes
tsconfig.json— added"types": ["bun-types"]sotscresolvesbun:testand theprocessglobal (bun-types was already installed; no new dependency).packages/shared/src/types.ts— renamedUser.userName→usernameto match the field name used by the route handlers and tests (cross-package field-name inconsistency).packages/shared/src/utils/pagination.ts— implemented thepaginate()stub: page slicing,total,totalPages(0 for empty input), echoedpage/pageSize, and safe empty/out-of-range handling.packages/api/src/middleware/auth.ts— fixed a case-sensitivity bug in the public-methods allow-list ("post"→"POST"); HTTP methods arrive uppercase, soPOST /userswas wrongly requiring a token. PUT/DELETE/PATCH still require a Bearer token (no security regression).packages/api/src/routes/users.ts— added the missingbadRequestimport from../lib/errors(was a runtimeReferenceError).Verification
bun test→ 22 pass, 0 fail (37 assertions)bunx tsc --noEmit→ clean, zero errorsAssumptions
username(lowercase) field name is canonical, since the tests and route handlers use it and tests must not change.Array.prototype.slicehandles out-of-range pages gracefully and no test asserts clamping.